linux-ext4 - Re: [RFC][PATCH 0/3] Extent base online defrag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Nov 2006 08:11:43 -0600
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	sho@...s.nec.co.jp, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [RFC][PATCH 0/3] Extent base online defrag

On Thu, 2006-11-09 at 07:46 -0500, Jeff Garzik wrote:
> sho@...s.nec.co.jp wrote:

> > I have written the patches of ioctl for extent base online defragment
> > and the command which call it.
> > These patches are at the experimental stage so they need many
> > improvements.  But they work well so far as basic defragmenter,
> > which means they are worth enough to examine my trial.
> > 
> > - Specify the target area in a file using the following structure:
> >   struct ext3_ext_defrag_data {
> > 	  loff_t start_offset; /* start offset to defrag in bytes */
> > 	  loff_t defrag_size;  /* size of defrag in bytes */
> >   }
> >   It uses loff_t so that the size of the structure is identical on
> >   both 32 bits and 64 bits architecture.
> >   Block allocation, including searching for the free contiguous
> >   blocks, is implemented in kernel.
> 
> NAK the ioctl approach.

I agree it shouldn't go into mainline this way, but while the details of
the proper interface are debated, this implementation at least allows
the core function to be tested & reviewed.

> People who like ioctls are just holdovers from non-Linux OS's.
> 
> 	Jeff

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html