linux-ext4 - Re: [PATCH 5/6] ext2 balloc: say rb_entry not list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Nov 2006 15:30:50 -0800
From:	Mingming Cao <cmm@...ibm.com>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	Andrew Morton <akpm@...l.org>, Mel Gorman <mel@...net.ie>,
	"Martin J. Bligh" <mbligh@...igh.org>,
	linux-kernel@...r.kernel.org,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry

On Tue, 2006-11-28 at 17:43 +0000, Hugh Dickins wrote:
> The reservations tree is an rb_tree not a list, so it's less confusing to
> use rb_entry() than list_entry() - though they're both just container_of().
> 
> Signed-off-by: Hugh Dickins <hugh@...itas.com>
> ---
> 

Acked.

Thanks,
Mingming
>  fs/ext2/balloc.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- 2.6.19-rc6-mm2/fs/ext2/balloc.c	2006-11-24 08:18:02.000000000 +0000
> +++ linux/fs/ext2/balloc.c	2006-11-27 19:28:41.000000000 +0000
> @@ -156,7 +156,7 @@ restart:
> 
>  	printk("Block Allocation Reservation Windows Map (%s):\n", fn);
>  	while (n) {
> -		rsv = list_entry(n, struct ext2_reserve_window_node, rsv_node);
> +		rsv = rb_entry(n, struct ext2_reserve_window_node, rsv_node);
>  		if (verbose)
>  			printk("reservation window 0x%p "
>  				"start: %lu, end: %lu\n",
> @@ -753,7 +753,7 @@ static int find_next_reservable_window(
> 
>  		prev = rsv;
>  		next = rb_next(&rsv->rsv_node);
> -		rsv = list_entry(next,struct ext2_reserve_window_node,rsv_node);
> +		rsv = rb_entry(next,struct ext2_reserve_window_node,rsv_node);
> 
>  		/*
>  		 * Reached the last reservation, we can just append to the
> @@ -995,7 +995,7 @@ static void try_to_extend_reservation(st
>  	if (!next)
>  		my_rsv->rsv_end += size;
>  	else {
> -		next_rsv = list_entry(next, struct ext2_reserve_window_node, rsv_node);
> +		next_rsv = rb_entry(next, struct ext2_reserve_window_node, rsv_node);
> 
>  		if ((next_rsv->rsv_start - my_rsv->rsv_end - 1) >= size)
>  			my_rsv->rsv_end += size;

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html