linux-ext4 - Re: [Resubmit][Patch 0/2] Persistent preallocation in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jan 2007 16:33:52 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	Mingming Cao <cmm@...ibm.com>
CC:	"Amit K. Arora" <aarora@...ux.vnet.ibm.com>,
	linux-ext4@...r.kernel.org, suparna@...ibm.com, alex@...sterfs.com,
	suzuki@...ibm.com
Subject: Re: [Resubmit][Patch 0/2] Persistent preallocation in ext4

Mingming Cao wrote:
> Amit K. Arora wrote:
> 
>> Outstanding Issues:
>> ------------------
>> (1) The final interface is yet to be decided. We have the option of
>> chosing from one of these:
>> 	a> modifying posix_fallocate() in glibc
>> 	b> using fcntl
>> 	c> using ftruncate, or
>> 	d> using the ioctl interface.
>>
>>   If we go with ioctl interface, we need to chose the return
>> value from the ioctl. We should either return "0" for success and
>> errno for failure, or we should be returning number of bytes
>> preallocated.
>>
> 
> Now I am more prefer just return 0 for success. Returning the number of 
> bytes preallocated back to userspace might be helpful in the case when 
> the specified window contains blocks already being allocated, but this 
> should not be a common case.

I tend to agree; I'm not exactly sure what the "bytes/blocks allocated"
return would be useful for?  What would the caller do with this information?

Also, is ftruncate really even an option for this interface?  Wouldn't
that mean the end of sparse files?

Thanks,
-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html