Date:	Thu, 01 Feb 2007 19:32:19 +0000
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Nikolai Joukov <kolya@...sunysb.edu>
Subject: Re: [Resubmit][PATCH 5/5] Secure Deletion and Trash-Bin Support
	for Ext4

On Thu, 2007-02-01 at 12:17 -0500, Nikolai Joukov wrote:

> > I don't have a strong opinion for or against the function and your
> > design.  The only potential problem I see in the approach is that
> > the .trash directory may conflict with some other use of the same name.
> > Since this is primarily vfs function, you'll probably get a wider
> > audience on linux-fsdevel.
> 
> Well, I guess lost+found has the same problem but it is not a problem at
> all to pick some other (longer) name.

Right, I didn't see it as a show-stopper, just something to consider.
> 
> > Have you considered putting ALL of the function in the vfs layer?  It
> > looks like this could be done without touching any code in the
> > individual file systems.
> 
> Unfortunately, we need some file system-specific code to access per-file
> secure deletion and per-file trash bit attributes.  These attributes are
> supported only by some file systems and in different ways.  

Yeah, I did see that.  I wonder adding some inode or file operation just
to query the existence of those attributes (or something more generic)
would be too ugly.

> We need no
> file system-specific code to support trash-bin deletion for whole file
> systems.
> 
> Nikolai.
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hosted by DataForce ISP - Powered by Openwall GNU/*/Linux