linux-ext4 - Re: [RFC][PATCH 2/3] Move the file data to the new blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Feb 2007 21:45:37 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	sho@...s.nec.co.jp, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [RFC][PATCH 2/3] Move the file data to the new blocks

Andrew Morton wrote:
> On Tue, 16 Jan 2007 21:05:20 +0900
> sho@...s.nec.co.jp wrote:

...

>> +ext4_ext_replace_branches(struct inode *org_inode, struct inode *dest_inode,
>> +			pgoff_t from_page,  pgoff_t dest_from_page,
>> +			pgoff_t count_page, unsigned long *delete_start) 
>> +{
>> +	struct ext4_ext_path *org_path = NULL;
>> +	struct ext4_ext_path *dest_path = NULL;
>> +	struct ext4_extent   *oext, *dext;
>> +	struct ext4_extent   tmp_ext;
>> +	int	err = 0;
>> +	int	depth;
>> +	unsigned long from, count, dest_off, diff, replaced_count = 0;
> 
> These should be sector_t, shouldn't they?

At some point should we start using blkcnt_t properly? 
(block-in[-large]-file, not block-in[-large]-device?)  I think that's 
what it was introduced for, although it's not in wide use at this point.

I guess the type really isn't used anywhere else; just in the inode's 
i_blocks.  Hmm.

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html