lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Mar 2007 09:55:23 -0400 From: Theodore Tso <tytso@....edu> To: "Brian D. Behlendorf" <behlendorf1@...l.gov> Cc: linux-ext4@...r.kernel.org, adilger@...sterfs.com, wartens2@...l.gov Subject: Re: e2fsprogs coverity patch <cid-01.diff> On Fri, Feb 09, 2007 at 06:08:16PM -0800, Brian D. Behlendorf wrote: > Found 2 of the three places where a return code for ext2fs_write_inode() was > not being checked. > > > Index: e2fsprogs+chaos/resize/resize2fs.c > =================================================================== > --- e2fsprogs+chaos.orig/resize/resize2fs.c > +++ e2fsprogs+chaos/resize/resize2fs.c > @@ -1303,7 +1303,9 @@ static int check_and_change_inodes(ext2_ > retval = ext2fs_read_inode(is->rfs->old_fs, dir, &inode); > if (retval == 0) { > inode.i_mtime = inode.i_ctime = time(0); > - ext2fs_write_inode(is->rfs->old_fs, dir, &inode); > + retval = ext2fs_write_inode(is->rfs->old_fs, dir, &inode); > + if (retval) > + return DIRENT_ERROR; > } The new lines should read: is->err = ext2fs_write_inode(...) if (is->err) return DIRENT_ABORT I'll fix up the patch before committing. > Index: e2fsprogs+chaos/e2fsck/emptydir.c > =================================================================== > --- e2fsprogs+chaos.orig/e2fsck/emptydir.c n.b. emptydir.c is the ultimate in dead code. It was some code that I never finished, and it's not linked into e2fsck at all (emptydir.c/o is not mentioned in the Makefile at all :-). - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists