linux-ext4 - [PATCH] - Make mke2fs.c defaults match mke2fs.conf defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 May 2007 11:31:22 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH] - Make mke2fs.c defaults match mke2fs.conf defaults

One of our testers filed a bug that said "mkfs.ext3 is much slower when mke2fs.conf is missing..."

This is because the shipped defaults in mke2fs.conf do not match the shipped defaults in the
mkfs code itself; he wound up making a 1k block filesystem on a very large block device,
for example.

So - How about this patch, to bring them back into line?  Which makes me wonder; having
"defaults" in 2 different places is bound to get out of sync; should we instead generate
both code & config file defaults (and maybe man page defaults) from a common source?

Anyway, here's a patch to bring mke2fs.conf and mke2fs.c into line for current defaults...

Thanks,
-Eric

Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Index: e2fsprogs-hg/misc/mke2fs.c
===================================================================
--- e2fsprogs-hg.orig/misc/mke2fs.c
+++ e2fsprogs-hg/misc/mke2fs.c
@@ -1288,7 +1288,8 @@ static void PRS(int argc, char *argv[])
 	tmp = tmp2 = NULL;
 	if (fs_param.s_rev_level != EXT2_GOOD_OLD_REV) {
 		profile_get_string(profile, "defaults", "base_features", 0,
-				   "filetype,sparse_super", &tmp);
+				   "sparse_super,filetype,resize_inode,dir_index",
+				   &tmp);
 		profile_get_string(profile, "fs_types", fs_type, 
 				   "base_features", tmp, &tmp2);
 		edit_feature(tmp2, &fs_param.s_feature_compat);
@@ -1365,7 +1366,7 @@ static void PRS(int argc, char *argv[])
 	
 	if (blocksize <= 0) {
 		profile_get_integer(profile, "defaults", "blocksize", 0,
-				    1024, &use_bsize);
+				    4096, &use_bsize);
 		profile_get_integer(profile, "fs_types", fs_type, 
 				    "blocksize", use_bsize, &use_bsize);
 


-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html