linux-ext4 - Re: Patch to support LUKS UUIDs in libblkid

lists.openwall.net		lists / announce john-users owl-users popa3d-users / xvendor oss-security / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4
Open Source and information security mailing list archives

This website is powered by Openwall GNU/*/Linux security-enhanced OS

[<prev] [next>] [<thread-prev] [thread-next>] [month] [year] [list]

Date:	Tue, 05 Jun 2007 09:20:23 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Karsten Hopp <karsten@...hat.com>
Subject: Re: Patch to support LUKS UUIDs in libblkid

Karsten Hopp wrote:
> Hello,
> 
> I've already posted this at the e2fsprogs sourceforge site, but our 
> e2fsprogs maintainer
> suggested that I should post it here as well for a review:
> 
> 
> Attached is a patch to add cryptsetup-luks UUID detection in libblkid.so
> This is required when we want to use UUIDs instead of hardcoded device 
> names for
> encrypted partitions.

Hi Karsten, in the patch you posted, need to remove the 
__BLKID_ATTR((unused)) from:

+static int probe_luks(struct blkid_probe *probe,
+		       struct blkid_magic *id __BLKID_ATTR((unused)),
+		       unsigned char *buf)
+{

since id is being used now.

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html