linux-ext4 - Re: [RFC][PATCH 1/12] new ext4 group desc struct in e2fsprogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2007 13:44:22 +0200
From:	Valerie Clement <valerie.clement@...l.net>
To:	Andreas Dilger <adilger@...sterfs.com>
Cc:	Theodore Tso <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [RFC][PATCH 1/12] new ext4 group desc struct in e2fsprogs

Andreas Dilger wrote:
> On Jun 11, 2007  18:42 +0200, Valerie Clement wrote:
>> @@ -213,7 +213,11 @@ struct struct_ext2_filsys {
>>  	int				fragsize;
>>  	dgrp_t				group_desc_count;
>>  	unsigned long			desc_blocks;
>> +#ifdef _EXT4FS_
>> +	struct ext4_group_desc *	group_desc;
>> +#else
>>  	struct ext2_group_desc *	group_desc;
>> +#endif
> 
> The way similar changes were incorporated into e2fsprogs in the past
> (e.g. large inode support) is to pass an ext2_group_desc around and
> in places where access to the "large" part of the struct are needed
> this is typecast and conditional upon the appropriate superblock field
> or feature, as it is in the kernel.  This also avoids the need to change
> the parameter everywhere.
> 
> This is important because even "ext4" filesystems may only have 32-byte
> group descriptors if they are formatted as ext3 and upgraded.
> 
> For large inodes, this is using "s_inode_size", and for the group
> descriptor it should use "s_desc_size" and INCOMPAT_64BIT.
> 

Yes, I see the problem. I'll make the changes in this way.
Thanks,
   Valérie

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html