Date:	Wed, 1 Aug 2007 02:14:09 -0500
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.

On Aug 01, 2007  11:44 +0530, Aneesh Kumar K.V wrote:
> Andreas Dilger wrote:
> >On Aug 01, 2007  07:34 +0530, Aneesh Kumar K.V wrote:
> >>When running mke2fs, if a file system is detected
> >>on the device, we use Undo I/O manager as the io manager.
> >>This helps in reverting the changes made to the filesystem
> >>in case we wrongly selected the device.
> >>
> >>The environment variable MKE2FS_SCRATCH_DIR
> >>is used to indicate the  directory within which the tdb
> >>file need to be created. The file will be named mke2fs-XXXXXX
> >
> >It might be more useful to have "mke2fs-{dev}-{timestamp}" as
> >the filename, so that it is clear where the image came from.
> >
> 
> I added it as a FIXME!! in the code. So i was intending to do it.
> 
> +	/* FIXME!! Should we generate Unique file name ?? */
> +	sprintf(tdb_file, "%s/mke2fs-XXXXXX", tdb_dir);

I don't think the "uniqueness" is as important as the fact that
having the dev and timestamp makes it easier to know which undo
file is related to a particular filesystem.  In that regard, the
undo file should also contain the filesystem UUID in addition to
the mtime to ensure it is being replayed on the same filesystem.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hosted by DataForce ISP - Powered by Openwall GNU/*/Linux