linux-ext4 - patch ext4_ext_put_in_cache-uses-__u32-to-receive-physical-block-number.patch queued to -stable tree

Open Source and information security mailing list archives

Date:	Tue, 07 Aug 2007 01:24:58 -0700
From:	<gregkh@...e.de>
To:	cmm@...ibm.com, akpm@...ux-foundation.org, gregkh@...e.de,
	linux-ext4@...r.kernel.org, yanzheng@...n.com
Cc:	<stable-commits@...r.kernel.org>
Subject: patch ext4_ext_put_in_cache-uses-__u32-to-receive-physical-block-number.patch queued to -stable tree


This is a note to let you know that we have just queued up the patch titled

     Subject: "ext4_ext_put_in_cache" uses __u32 to receive physical block number

to the 2.6.22-stable tree.  Its filename is

     ext4_ext_put_in_cache-uses-__u32-to-receive-physical-block-number.patch

A git repo of this tree can be found at 
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary


>From stable-bounces@...ux.kernel.org Tue Jul 31 00:48:13 2007
From: Mingming Cao <cmm@...ibm.com>
Date: Tue, 31 Jul 2007 00:37:46 -0700
Subject: "ext4_ext_put_in_cache" uses __u32 to receive physical block number
To: torvalds@...ux-foundation.org
Cc: akpm@...ux-foundation.org, linux-ext4@...r.kernel.org, cmm@...ibm.com, stable@...nel.org, yanzheng@...n.com
Message-ID: <200707310737.l6V7bk50021902@...p1.linux-foundation.org>


From: Mingming Cao <cmm@...ibm.com>

Yan Zheng wrote:

> I think I found a bug in ext4/extents.c, "ext4_ext_put_in_cache" uses
> "__u32" to receive physical block number.  "ext4_ext_put_in_cache" is
> used in "ext4_ext_get_blocks", it sets ext4 inode's extent cache
> according most recently tree lookup (higher 16 bits of saved physical
> block number are always zero). when serving a mapping request,
> "ext4_ext_get_blocks" first check whether the logical block is in
> inode's extent cache. if the logical block is in the cache and the
> cached region isn't a gap, "ext4_ext_get_blocks" gets physical block
> number by using cached region's physical block number and offset in
> the cached region.  as described above, "ext4_ext_get_blocks" may
> return wrong result when there are physical block numbers bigger than
> 0xffffffff.
>

You are right.  Thanks for reporting this!

Signed-off-by: Mingming Cao <cmm@...ibm.com>
Cc: Yan Zheng <yanzheng@...n.com>
Cc: <linux-ext4@...r.kernel.org>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

--- a/fs/ext4/extents.c~ext4_ext_put_in_cache-uses-__u32-to-receive-physical
+++ a/fs/ext4/extents.c
@@ -1544,7 +1544,7 @@ int ext4_ext_walk_space(struct inode *in
 
 static void
 ext4_ext_put_in_cache(struct inode *inode, __u32 block,
-			__u32 len, __u32 start, int type)
+			__u32 len, ext4_fsblk_t start, int type)
 {
 	struct ext4_ext_cache *cex;
 	BUG_ON(len == 0);
_

_______________________________________________
stable mailing list
stable@...ux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable



Patches currently in stable-queue which might be from cmm@...ibm.com are

queue-2.6.22/ext4_ext_put_in_cache-uses-__u32-to-receive-physical-block-number.patch
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives