linux-ext4 - Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Sep 2007 09:31:56 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Theodore Tso <tytso@....edu>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH e2fsprogs] - ignore bind mounts in fsck

Theodore Tso wrote:
> On Wed, Sep 19, 2007 at 03:20:14PM -0500, Eric Sandeen wrote:
>> An entry like this in /etc/fstab:
>>
>> /foo	/bar	ext3	bind,defaults	1 3
>>
>> will stop boot, as fsck.ext3 tries to check it and fails:
>>
>> e2fsck 1.40.2 (12-Jul-2007)
>> fsck.ext3: Is a directory while trying to open /foo
>>
>> The superblock could not be read or does not describe a correct ext2
>> filesystem. ...
>>
>> Granted, asking for fsck of a bind mount in the fstab is a bit odd, 
>> but it doesn't seem like it should stop the boot process if you make
>> this mistake.
> 
> That's fair, but note that the dump number and fsck pass number really
> should be zero in the fstab entry.  i.e., it really should be "0 0",
> or just plain ommitted.

Agreed.  If you think fsck shouldn't silently cope with this mistake,
and instead punish the user for it (it is what they asked for, after
all), I'm ok with that too.  I'm willing to close my end as NOTABUG if
you don't want to take this patch.  :)

(FWIW, this is RH bug #151533)

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html