linux-ext4 - Re: [RFC/PATCH] ext4: Clear the reservation window correctly with delayed allocation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Oct 2007 14:24:42 +0300
From:	Alex Tomas <bzzz.tomas@...il.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	Andreas Dilger <adilger@...sterfs.com>,
	Eric Sandeen <sandeen@...hat.com>,
	Valerie Clement <valerie.clement@...l.net>,
	Theodore Tso <tytso@....edu>, Mingming Cao <cmm@...ibm.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [RFC/PATCH] ext4: Clear the reservation window correctly with
 delayed allocation.

what if writepages went through 100 pages only and another 100 are left because
negative wbc->nr_to_write?

thanks, Alex

Aneesh Kumar K.V wrote:
> @@ -1410,7 +1410,14 @@ out:
> static int ext4_da_writepages(struct address_space *mapping,
>                   struct writeback_control *wbc)
> {
> -    return mpage_da_writepages(mapping, wbc, ext4_da_get_block_write);
> +    int retval;
> +    retval = mpage_da_writepages(mapping, wbc, ext4_da_get_block_write);
> +    if (!retval) {
> +        /* if writepages is successfull discard the reservation */
> +        ext4_discard_reservation(mapping->host);
> +    }
> +
> +    return retval;
> }
> 
> static void ext4_da_invalidatepage(struct page *page, unsigned long offset)
> 
> 
> -aneesh
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html