linux-ext4 - Re: [PATCH] ext4: Fix the soft lockup with multi block allocator.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Dec 2007 21:18:45 +0300
From:	Alex Tomas <alex.tomas@....com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	tytso@....edu, cmm@...ibm.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix the soft lockup with multi block allocator.

Andreas Dilger wrote:
> On Dec 21, 2007  16:39 +0530, Aneesh Kumar K.V wrote:
>> @@ -3790,7 +3782,9 @@ repeat:
>>  
>>  	/* if we still need more blocks and some PAs were used, try again */
>>  	if (free < needed && busy) {
>> +		busy = 0;
>>  		ext4_unlock_group(sb, group);
>> +		schedule_timeout(HZ);
>>  		goto repeat;
>>  	}
> 
> Is there nothing we could actually wait on instead of just sleeping for
> 1 second?

actually it was done for simplicity - in my tests busy PA happened quite rare.
I have no objection to improve this with special wait queue.

thanks, Alex

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html