lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 23 Jan 2008 08:10:20 -0600
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	"Theodore Ts'o" <tytso@....EDU>
Cc:	linux-ext4@...r.kernel.org, Mingming Cao <cmm@...ibm.com>,
	Takashi Sato <t-sato@...jp.nec.com>,
	Akira Fujita <a-fujita@...jp.nec.com>
Subject: Re: ext4-online-defrag-free-space-fragmentation.patch uses
	do_fsync()


> diff --git a/fs/ext4/defrag.c b/fs/ext4/defrag.c
> index 4ef3dc0..19d2cfd 100644
> --- a/fs/ext4/defrag.c
> +++ b/fs/ext4/defrag.c
> @@ -632,8 +632,9 @@ static int ext4_ext_defrag_victim(struct file *target_filp,
>  		}
> 
>  		/* Sync journal blocks before reservation */
> -		if (do_fsync(target_filp, 0)) {
> -			printk(KERN_ERR "defrag: failed do_fsync\n");
> +		ret = ext4_force_commit(sb);
> +		if (ret) {
> +			printk(KERN_ERR "defrag: failed do_fsync (%d)\n", ret);

I'd think you'd want to change the printk text as well.  "defrag: failed
ext4_force_commit (%d)\n" maybe?

>  			goto ERR;
>  		}
>  	}

-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ