linux-ext4 - Re: [PATCH] don't set extents flag for _any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2008 21:22:56 -0800
From:	Mingming Cao <cmm@...ibm.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] don't set extents flag for _any_ symlinks

Thanks, Added to patch queue
On Mon, 2008-02-18 at 16:27 -0600, Eric Sandeen wrote:
> As symlinks are limited to a single block anyway, and e2fsck
> doesn't expect to find it set, don't set the extents flag on 
> any type of symlinks at all: fast/in-inode, or the 
> external-block flavor.
> 
> There are a lot of filesystems out there by now w/ exent-style 
> symlink blocks though, so e2fsck should probably be able to 
> repair that at some point...
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> 
> ---
> 
> Index: linux-2.6.24/fs/ext4/namei.c
> ===================================================================
> --- linux-2.6.24.orig/fs/ext4/namei.c
> +++ linux-2.6.24/fs/ext4/namei.c
> @@ -2223,7 +2226,6 @@ retry:
>  		inode->i_op = &ext4_fast_symlink_inode_operations;
>  		memcpy((char*)&EXT4_I(inode)->i_data,symname,l);
>  		inode->i_size = l-1;
> -		EXT4_I(inode)->i_flags &= ~EXT4_EXTENTS_FL;
>  	}
>  	EXT4_I(inode)->i_disksize = inode->i_size;
>  	err = ext4_add_nondir(handle, dentry, inode);
> 
> Index: linux-2.6.24/fs/ext4/ialloc.c
> ===================================================================
> --- linux-2.6.24.orig/fs/ext4/ialloc.c
> +++ linux-2.6.24/fs/ext4/ialloc.c
> @@ -744,7 +744,7 @@ got:
>  		ext4_std_error(sb, err);
>  		goto fail_free_drop;
>  	}
> -	if (test_opt(sb, EXTENTS)) {
> +	if (test_opt(sb, EXTENTS) && !S_ISLNK(mode)) {
>  		EXT4_I(inode)->i_flags |= EXT4_EXTENTS_FL;
>  		ext4_ext_tree_init(handle, inode);
>  		err = ext4_update_incompat_feature(handle, sb,
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html