linux-ext4 - Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

lists.openwall.net		lists / announce john-users owl-users popa3d-users / xvendor oss-security / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4
Open Source and information security mailing list archives

This website is powered by Openwall GNU/*/Linux security-enhanced OS

[<prev] [next>] [<thread-prev] [thread-next>] [month] [year] [list]

Date:	Thu, 06 Mar 2008 15:20:09 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Andreas Dilger <adilger@....com>
Subject: Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

Hi Andreas,
> On Mar 06, 2008  09:01 +0900, Akira Fujita wrote:
>   
>> Change the name of functions (ext4_ext_xxx -> ext4_defrag_xxx)
>> and some cleanups.
>>
>> -int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block,
>> -			ext4_lblk_t num, ext_prepare_callback func,
>> -			void *cbdata)
>> -{
>>     
>
> We were just going to be using this function for the FIEMAP support.
> I think there are several other functions which are not specific
> to defrag, so they shouldn't be renamed to be defrag specific.
>   

ext4_ext_walk_space is no longer used by ext4 online defrag.
So I just removed from defrag.c not renamed.

Shouldn't I remove ext4_ext_walk_space from defrag
for support FIEMAP?
I think it should be moved to extents.c

Regards, Akira

-- 
Akira Fujita <a-fujita@...jp.nec.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html