linux-ext4 - Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Mar 2008 10:40:21 -0400
From:	Theodore Tso <tytso@....EDU>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Matthias Koenig <mkoenig@...e.de>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE
	boxes

On Fri, Mar 14, 2008 at 09:13:03AM -0500, Eric Sandeen wrote:
> Yep, there were 2 problems.
> 
> One was that inode_scan_and_fix() wasn't moving all of large inodes.
> 
> The other was that ext2fs_swap_inode_full was doing bad things for
> in-inode attrs on big endian boxes, that was the patch in this thread
> which isn't in the repo yet, but is in fact needed.
> 
> I suppose that the iterative nature of my fix for this problem didn't
> help Ted keep things straight, sorry.

I actually *prefer* multiple patches, actually, but what works best
when there is a series of patches is to resend the whole patch stack
using git-format-patch or git-send-email --- or set up your own git
repository on the network (or use repo.or.cz) and send me a pull
request.  But that requires much more use of git.  :-)

In any case, I'll pull in the last change, and this time I promise
I'll be careful about remembering to use --author.  That *is*
something I should be doing, but I certainly appreciate people using
git's facilities to make my life easier, thanks.

      		    	    	 	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html