lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Mar 2008 14:17:56 +0100 From: Jan Kara <jack@...e.cz> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, jengelh@...putergmbh.de, mjt@....msk.ru Subject: Re: [PATCH 1/4] quota: Quota core changes for quotaon on remount On Thu 13-03-08 14:48:02, Andrew Morton wrote: > On Thu, 13 Mar 2008 14:04:12 +0100 > Jan Kara <jack@...e.cz> wrote: > > > +static inline int DQUOT_ON_REMOUNT(struct super_block *sb) > > +{ > > + int cnt; > > + int ret = 0, err; > > + > > + if (!sb->s_qcop || !sb->s_qcop->quota_on) > > + return -ENOSYS; > > + for (cnt = 0; cnt < MAXQUOTAS; cnt++) { > > + err = sb->s_qcop->quota_on(sb, cnt, 0, NULL, 1); > > + if (err < 0 && !ret) > > + ret = err; > > + } > > + return ret; > > +} > > + > > That's about ten times too large to be inlined. Oh well. Right, will send a cleanup patch. Thanks for spotting this. > Sometime could you please take a look at uninlining some of the porkier > functions in quotaops.h, and maybe convert them to lower case? > > > For the latter we can do > > #define DQUOT_ON_REMOUNT(sb) dquot_on_remount(sb) > > etc, then remove those macros when everything has been converted and we've > given any out-of-tree filesytem developers time to update, etc. Good idea. Will do. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists