linux-ext4 - Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 19 Mar 2008 10:05:33 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Solofo.Ramangalahy@...l.net
Cc:	tytso@....edu, cmm@...ibm.com, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

Hello Solofo,
> Hello,
>
> Akira Fujita writes:
>  > -			printk(KERN_ERR "defrag: failed ext4_ext_defrag\n");
>  > -			goto ERR;
>  > +			printk(KERN_ERR "ext4 defrag: "
>  > +				"Moving victim file failed. ino [%lu]\n",
>  > +				ext_info->ino);
>
> This triggers this warning:
> fs/ext4/defrag.c: In function 'ext4_defrag_move_victim':
> fs/ext4/defrag.c:458: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'long long unsigned int'
>
> (ext4-online-defrag-free-space-fragmentation.patch from ext4-patch-queue 36c86f09d6ac97c2797a1a94d76e2fc1dc3b03f8)
>
Thank you for notification.
And sorry for the delay fix, it has already been pointed out by Mingming.

Mingming, could you replace attached file with ext4 patch queue's ?

Regards Akira, 


Signed-off-by: Akira Fujita <a-fujita@...jp.nec.com>
---
 defrag.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.25-rc5-ext4-org/fs/ext4/defrag.c	2008-03-19 07:16:40.000000000 +0900
+++ linux-2.6.25-rc5-full/fs/ext4/defrag.c	2008-03-19 08:31:01.000000000 +0900
@@ -454,7 +454,7 @@ static int ext4_defrag_move_victim(struc
 			ext_info->ext[i].len, goal, DEFRAG_FORCE_VICTIM, &ext);
 		if (ret < 0) {
 			printk(KERN_ERR "ext4 defrag: "
-				"Moving victim file failed. ino [%lu]\n",
+				"Moving victim file failed. ino [%llu]\n",
 				ext_info->ino);
 			goto err;
 		}

Download attachment "ext4-online-defrag-free-space-fragmentation.patch" of type "application/octet-stream" (22241 bytes)