linux-ext4 - Re: Ordered mode rewrite patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2008 14:42:58 -0400
From:	Josef Bacik <jbacik@...hat.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Nathan Grennan <jack@...nusx-1.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	linux-ext4@...r.kernel.org
Subject: Re: Ordered mode rewrite patch

On Tue, Apr 08, 2008 at 02:11:49PM +0200, Jan Kara wrote:
>   Hello,
> 
>   attached is a jumbo patch that reverses locking order of transaction
> start and page lock in ext3 and rewrites handling of ordered data mode in
> JBD and ext3. Note that the patch will break compilation of ext4 and OCFS2.
> The patch survives LTP run on my test machine so it shouldn't eat your data
> immediately but bugs are of course possible...
>   I'm very interested in any results (both positive and negative) you could
> get with it :). Thanks for testing it.
> 
> 									Honza
>

Hey Jan,

I just hit a problem with your patch.  In journal_destroy() we do a
iput(journal->j_inode) and then kfree the journal, so when the iput comes back
into journal_release_jbd_inode we are doing a use after free which in my case
resulted in a panic.  I was going to fix it but I figure since this is still in
transit you would have to just rewrite it so I'm not going to attach one, just
giving you a heads up.  Let me know if my explanation wasn't clear enough.
Thanks much,

Josef 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html