linux-ext4 - Re: Using tgid instead of pid in ext3_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2008 07:57:05 +0700
From:	"Mulyadi Santosa" <mulyadi.santosa@...il.com>
To:	"Manish Katiyar" <mkatiyar@...il.com>
Cc:	"Kernel Newbies" <kernelnewbies@...linux.org>,
	linux-ext4@...r.kernel.org
Subject: Re: Using tgid instead of pid in ext3_find_near()

Ehmmm....

On Tue, Apr 29, 2008 at 2:07 AM, Manish Katiyar <mkatiyar@...il.com> wrote:
> Hi,
>
>  In the function ext*_find_near() we are using pid to have the locality
>  of the blocks for the files which have same functionality. Shouldn't
>  we be using "current->tgid" here instead ??
>
>  410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind)
>   411 {
>  .........
>  ........
>  433  colour = (current->pid % 16) *
>   434    (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16);
>  ........

Because each threads even on same thread group doesn't need to share
open file descriptors?

regards,

Mulyadi.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html