linux-ext4 - Re: [patch 2/4] ext4: fix error processing in mb_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 13 Jul 2008 21:07:56 -0400
From:	Theodore Tso <tytso@....edu>
To:	akpm@...ux-foundation.org
Cc:	cmm@...ibm.com, linux-ext4@...r.kernel.org, shen@...fujitsu.com
Subject: Re: [patch 2/4] ext4: fix error processing in mb_free_blocks

On Sat, Jul 12, 2008 at 11:26:20PM -0700, akpm@...ux-foundation.org wrote:
> From: Shen Feng <shen@...fujitsu.com>
> 
> The error processing of the return value of mb_free_blocks is meanless
> because it only returns 0.  This fix includes
> 
> - make mb_free_blocks return void
> 
> - remove the error processing part in callers
> 
> - unlock group before calling ext4_error in mb_free_blocks
> 
> Signed-off-by: Shen Feng <shen@...fujitsu.com>
> Cc: Mingming Cao <cmm@...ibm.com>
> Cc: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html