linux-ext4 - Small change to the ext4 journal credits reservation patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 02 Aug 2008 01:34:52 -0400
From:	"Theodore Ts'o" <tytso@....edu>
To:	cmm@...ibm.com
Cc:	linux-ext4@...r.kernel.org
Subject: Small change to the ext4 journal credits reservation patch

Mingming,

FYI, I checked in a minor change to the ext4 journal credits reservation
patch into the ext4 patch queue.

I changed a printk in ext4_da_writepgaes() from:

                      printk(KERN_EMERG "%s: Not enough credits to flush %ld p
                              wbc->nr_to_write);

to this:

                      printk(KERN_EMERG "ext4_da_writepages: jbd2_start: "
                             "%ld pages, ino %d; err %d\n",
                             wbc->nr_to_write, inode->i_ino, ret)

As it turns out, the primary way this printk triggers is right after a
filesystem is remounted read-only.  My change provides a bit more useful
information.  

I'm not sure whether the read-only remount is failing to force changes
to disk, or the pages are erroneously left dirty; but this should help
us figure out exactly what is going on.  As I said earlier, I don't
think this is the fault of the journal credits patch, but it is exposing
this potential bug in a much more visible way.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html