linux-ext4 - Build error with patchqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2008 23:12:09 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Build error with patchqueue

Hi Ted,

The patchqueue have the below build error.

CC      fs/ext4/inode.o
fs/ext4/inode.c: In function ‘ext4_delete_inode’:
fs/ext4/inode.c:230: error: implicit declaration of function
‘ext4_ext_journal_restart’
make[1]: *** [fs/ext4/inode.o] Error 1
make: *** [fs/ext4/] Error 2
kvaneesh@...walker:/home/opensource/patches/work-tree/linux-review-ext-build$make
fs/ext4/

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 68f148c..70829d5 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -92,7 +92,7 @@ static void ext4_idx_store_pblock(struct ext4_extent_idx *ix, ext4_fsblk_t pb)
 	ix->ei_leaf_hi = cpu_to_le16((unsigned long) ((pb >> 31) >> 1) & 0xffff);
 }
 
-static int ext4_ext_journal_restart(handle_t *handle, int needed)
+int ext4_ext_journal_restart(handle_t *handle, int needed)
 {
 	int err;
 
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fe1570d..77ef18b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -190,6 +190,7 @@ static int ext4_journal_test_restart(handle_t *handle, struct inode *inode)
 /*
  * Called at the last iput() if i_nlink is zero.
  */
+int ext4_ext_journal_restart(handle_t *handle, int needed);
 void ext4_delete_inode (struct inode * inode)
 {
 	handle_t *handle;
@@ -228,7 +229,7 @@ void ext4_delete_inode (struct inode * inode)
 	 * the orphan list and set the dtime field.
 	 */
 	if (ext4_ext_journal_restart(handle, 3)) {
-	stop_handle:
+stop_handle:
 		ext4_journal_stop(handle);
 		goto no_delete;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html