linux-ext4 - Re: [PATCH] Add extent conversion support to chattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 12:47:52 -0400
From:	Theodore Tso <tytso@....EDU>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	Christoph Hellwig <hch@...radead.org>, adilger@....com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] Add extent conversion support to chattr

On Tue, Sep 09, 2008 at 09:58:14PM +0530, Aneesh Kumar K.V wrote:
> diff --git a/lib/e2p/fsetflags.c b/lib/e2p/fsetflags.c
> index 62189c9..d1bb9d9 100644
> --- a/lib/e2p/fsetflags.c
> +++ b/lib/e2p/fsetflags.c
> @@ -80,9 +80,19 @@ int fsetflags (const char * name, unsigned long flags)
>  	if (fd == -1)
>  		return -1;
>  	f = (int) flags;
> +	if (f & EXT4_EXTENTS_FL) {
> +		/* extent flags is set using  migrate ioctl */
> +		r = ioctl (fd, EXT4_IOC_MIGRATE, NULL);
> +		if (r == -1) {
> +			save_errno = errno;
> +			goto err_out;
> +		}
> +		f = (int)flags & ~EXT4_EXTENTS_FL;
> +	}

No, I wouldn't put this in libe2p; it probably should be in the chattr
program.  If you do it in chattr, it's much easier to have an
user-friendly error message if the EXT4_IOC_MIGRATE ioctl fails.

Also, it should only call EXT4_IOC_MIGRATE if the file was previously
not supporting extents.  Probably a bad idea to unconditionally call
EXT4_IOC_MIGRATE.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html