linux-ext4 - Unusual code in mballoc.c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 28 Sep 2008 11:56:12 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	linux-ext4@...r.kernel.org
Cc:	Alex Tomas <alex@...sterfs.com>, Mike Travis <travis@....com>
Subject: Unusual code in mballoc.c.

Hi all,

   A grep lead me to fs/ext4/mballoc.c:

Line 2551:
	for (i = 0; i < nr_cpu_ids; i++) {

This is more normally "for_each_possible_cpu(i)".

Line 4097:
	ac->ac_lg = &sbi->s_locality_groups[get_cpu()];
	put_cpu();

This is presumably someone suppressing a warning.   It should be:
	ac->ac_lg = &sbi->s_locality_groups[raw_smp_processor_id()];

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html