linux-ext4 - Re: [PATCH] e2fsprogs: exit from preenhalt if IO errors were encountered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 17:39:01 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: exit from preenhalt if IO errors were encountered

Eric Sandeen wrote:
> Resolves RH Bug 465679- e2fsck -p crashes with read-only DM device (e.g. logical volume)  
> 
> If a block device is unwritable, e2fsck -p gets into an infinite loop
> trying to preenhalt, close & flush the fs, which tries to flush the cache, 
> which gets a write error and calls preenhalt which tries to close & flush
> the fs ... ad infinitum.
> 
> Per Ted's suggestion just flag the ctx as "exiting" and short-circuit
> the infinite loop.
> 
> Tested by running e2fsck -p on a block device set read-only by BLKROSET.

Oh, thanks to Vlado Potisk for reporting this.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html