linux-ext4 - Re: [PATCH] jbd2: deregister proc on failure in jbd2_journal_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 2 Nov 2008 18:48:50 -0500
From:	Theodore Tso <tytso@....edu>
To:	Sami Liedes <sliedes@...hut.fi>
Cc:	sct@...hat.com, akpm@...ux-foundation.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] jbd2: deregister proc on failure in
	jbd2_journal_init_inode

On Sun, Nov 02, 2008 at 09:58:57PM +0200, Sami Liedes wrote:
> jbd2_journal_init_inode() does not call jbd2_stats_proc_exit() on all
> failure paths after calling jbd2_stats_proc_init(). This leaves
> dangling references to the fs in proc.
> 
> This patch fixes bug #11493.
> 
> Signed-off-by: Sami Liedes <sliedes@...hut.fi>
> 
> ---
> 
> I hope this is correct. I don't understand the code very well, but I
> did test my patch and it seems to fix the problem. Please don't hit me
> too hard, this is the first kernel patch I have ever submitted.

The patch looks good.  I'll get this into the ext4 patch queue and
queue it for submission to Linus.  I normally reference kernel bugs
via the full URL, i.e:

This patch fixes a bug reported by Sami Leides at:
http://bugzilla.kernel.org/show_bug.cgi?id=11493

...but that's just a tiny nit.   Thanks!!

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html