linux-ext4 - Re: [RFC PATCH -V3 9/9] ext4: Fix lockdep recursive locking warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Nov 2008 16:04:40 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	cmm@...ibm.com, tytso@....edu, sandeen@...hat.com,
	linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH -V3 9/9] ext4: Fix lockdep recursive locking warning

I got compile error on IA64:

fs/ext4/mballoc.c: In function ‘ext4_mb_add_groupinfo’:
fs/ext4/mballoc.c:2482: error: implicit declaration of function ‘__init_rwsem’


Aneesh Kumar K.V wrote:
> Indicate that the group locks can be taken in loop.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>  fs/ext4/mballoc.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index f58de20..34b9b7c 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2413,6 +2413,7 @@ ext4_mb_store_history(struct ext4_allocation_context *ac)
>  #define ext4_mb_history_init(sb)
>  #endif
>  
> +static struct lock_class_key alloc_sem_key[NR_BG_LOCKS];
>  
>  /* Create and initialize ext4_group_info data for the given group. */
>  int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group,
> @@ -2473,7 +2474,9 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group,
>  	}
>  
>  	INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list);
> -	init_rwsem(&meta_group_info[i]->alloc_sem);
> +	__init_rwsem(&meta_group_info[i]->alloc_sem,
> +			"&meta_group_info[i]->alloc_sem",
> +			&alloc_sem_key[i]);
>  	meta_group_info[i]->bb_free_root.rb_node = NULL;;
>  
>  #ifdef DOUBLE_CHECK
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html