linux-ext4 - Re: [PATCH, take2] percpu_counter: FBC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Dec 2008 20:32:44 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Travis <travis@....com>,
	"David S. Miller" <davem@...emloft.net>,
	linux kernel <linux-kernel@...r.kernel.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH, take2] percpu_counter: FBC_BATCH might be too big

On Sun, 07 Dec 2008 19:30:10 +0100 Eric Dumazet <dada1@...mosbay.com> wrote:

> > 
> > Do
> > 
> > 	$EDITOR  $(grep -l hotcpu_notifier */*.c)
> > 
> > and you'll see lots of code gets it right, and lots of code gets it wrong.
> 
> I see nothing interesting, I must be blind.
> 
> lib/percpu_counter.c: In function 'percpu_counter_startup':
> lib/percpu_counter.c:158: error: 'percpu_counter_hotcpu_callback' undeclared (first use in this function)
> lib/percpu_counter.c:158: error: (Each undeclared identifier is reported only once
> lib/percpu_counter.c:158: error: for each function it appears in.)
> make[1]: *** [lib/percpu_counter.o] Error 1

Perhaps you still had percpu_counter_hotcpu_callback inside #ifdef.

That a look at kernel/workqueue.c, fs/buffer.c.  No #ifdef CONFIG_HOTPLUG_CPU
needed at all.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html