linux-ext4 - Re: [PATCH] ext4: Fix to read empty directory blocks correctly in 64k blocksize filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Feb 2009 10:15:47 -0500
From:	Theodore Tso <tytso@....edu>
To:	Andreas Dilger <adilger@....com>
Cc:	Wei Yongjun <yjwei@...fujitsu.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix to read empty directory blocks correctly in
	64k blocksize filesystems

On Wed, Feb 11, 2009 at 12:48:16AM -0500, Andreas Dilger wrote:
> 
> I'm glad that the MAX_REC_LEN value is being kept, because "0" is
> too easily hit due to disk corruption.
> 

I'm not too worried about that, actually.  If there is a disk
corruption, we will detect it easily enough no matter which encoding
we use.  I am thinking though that neither 65535 nor 0 is the best way
of encoding 65536.  In fact, I would suggest the encoding 0x01.
Specifically, I suggest:

	     (rec_len & 65532) | ((rec_len >> 16) & 3)

This encodes valid rec_len values in the range 0 through 2**18-4, and
allows for maximum block sizes of up to 256k.  To retain backwards
compatibility, and to allow for a 256k blocksize, we can have a
special case where a rec_len of either 0 or 65535 means
EXT4_BLOCK_SIZE(s).

It's unlikely we'll see VM pages of up to 256k, but at some point we
might find that the Linux VM has been enhanced to support filesystem
block sizes > than the VM page size, at which point it might be useful
for some applications to allow very large filesystem block sizes.

    	 	      	       	    	  	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html