linux-ext4 - [nacked] ext2-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems.patch removed from -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 11 Feb 2009 09:13:10 -0800
From:	akpm@...ux-foundation.org
To:	yjwei@...fujitsu.com, linux-ext4@...r.kernel.org,
	mm-commits@...r.kernel.org
Subject: [nacked] ext2-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems.patch removed from -mm tree


The patch titled
     ext2: fix support for empty directory blocks in 64k blocksize filesystems
has been removed from the -mm tree.  Its filename was
     ext2-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems.patch

This patch was dropped because it was nacked

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: ext2: fix support for empty directory blocks in 64k blocksize filesystems
From: Wei Yongjun <yjwei@...fujitsu.com>

The rec_len field in the directory entry is 16 bits, so if the filesystem
is completely empty, rec_len of 0 is used to designate 65536 in e2fsprogs,
for the case where the directory entry takes the entire 64k block.

But if an empty directory is read, an error message will be output by
current kernels.  You can use the following commands to reproduce it.

  - mkfs.ext2 -b $(( 64 * 1024 )) /dev/sdc1
  - mount /dev/sda1 /mnt
  - cd /mnt/lost+found
  - ll
  - tail /var/log/messages
  EXT2-fs error (device sdc1): ext2_check_page: bad entry in \
  directory #11: : rec_len is smaller than minimal - offset=65536, \
  inode=0, rec_len=0, name_len=0
  EXT2-fs error (device sdc1): ext2_readdir: bad page in #11

Treat a rec_len of 0 as 65536, as e2fsprogs does.

Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>
Cc: <linux-ext4@...r.kernel.org>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 fs/ext2/dir.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN fs/ext2/dir.c~ext2-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems fs/ext2/dir.c
--- a/fs/ext2/dir.c~ext2-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems
+++ a/fs/ext2/dir.c
@@ -33,7 +33,7 @@ static inline unsigned ext2_rec_len_from
 {
 	unsigned len = le16_to_cpu(dlen);
 
-	if (len == EXT2_MAX_REC_LEN)
+	if (len == EXT2_MAX_REC_LEN || len == 0)
 		return 1 << 16;
 	return len;
 }
@@ -41,7 +41,7 @@ static inline unsigned ext2_rec_len_from
 static inline __le16 ext2_rec_len_to_disk(unsigned len)
 {
 	if (len == (1 << 16))
-		return cpu_to_le16(EXT2_MAX_REC_LEN);
+		return cpu_to_le16(0);
 	else
 		BUG_ON(len > (1 << 16));
 	return cpu_to_le16(len);
_

Patches currently in -mm which might be from yjwei@...fujitsu.com are

linux-next.patch
fs-jffs2-mallocc-kmem_cache_alloc-memset-kmem_cache_zalloc.patch
scsi-used-kmem_cache_zalloc-instead-of-kmem_cache_alloc-memset.patch
ext2-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems.patch
ext3-fix-support-for-empty-directory-blocks-in-64k-blocksize-filesystems.patch

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html