linux-ext4 - Re: [PATCH, RFC -V2 1/4] ext4: Add configurable run-time mballoc debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Aug 2009 16:23:24 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	linux-ext4@...r.kernel.org, Andreas Dilger <adilger@....com>,
	Alex Tomas <bzzz@....com>
Subject: Re: [PATCH, RFC -V2 1/4] ext4: Add configurable run-time mballoc
	debugging

On Sun, Aug 09, 2009 at 10:42:17PM -0500, Eric Sandeen wrote:
> Theodore Ts'o wrote:
> > Allow mballoc debugging to be enabled at run-time instead of just at
> > compile time.
> > 
> > Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> > ---
> >  fs/ext4/Kconfig   |    9 ++++++
> >  fs/ext4/mballoc.c |   81 ++++++++++++++++++++++++++++++++++++++--------------
> >  fs/ext4/mballoc.h |   16 ++++++++--
> >  3 files changed, 80 insertions(+), 26 deletions(-)
> 
> This looks fine to me, though is there any reason to add the debug
> verbosity level at this point, when it's all just "1?"

What I'm thinking about doing is to use a bitmask instead of a
verbosity level.  That way it will be possible to selectively enable
some debugging print messages and not others.

In the long run the right answer is to use ftrace instead, but this is
faster and more convenient when doing surgery/development on the
mballoc code.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html