linux-ext4 - Re: [PATCH] Fix counting routines in blknum.c to take/return _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 Sep 2009 13:41:18 -0400
From:	Nick Dokos <nicholas.dokos@...com>
To:	Theodore Tso <tytso@....edu>
Cc:	Nick Dokos <nicholas.dokos@...com>,
	Eric Sandeen <sandeen@...hat.com>,
	Justin Maggard <jmaggard10@...il.com>,
	Andreas Dilger <adilger@....com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] Fix counting routines in blknum.c to take/return __u32
 counts.

Theodore Tso <tytso@....edu> wrote:

> On Wed, Sep 02, 2009 at 05:02:22PM -0400, Nick Dokos wrote:
> > From e8c790ab8a0f06b4c89a5b6ddba2a36f033c742c Mon Sep 17 00:00:00 2001
> > From: Nick Dokos <nicholas.dokos@...com>
> > Date: Wed, 2 Sep 2009 16:52:09 -0400
> > Subject: [PATCH] Fix counting routines in blknum.c to take/return __u32 counts.
> > 
> > Several routines in lib/ext2fs/blknum.c:
> > 
> >         ext2fs_bg_free_blocks_count()
> >         ext2fs_bg_free_inodes_count()
> >         ext2fs_bg_used_dirs_count()
> >         ext2fs_bg_itable_unused()
> > 
> > and their _set() counterparts, operate as if they are dealing with
> > blk64_t quantities, but they should be dealing with __u32 counts
> > instead.
> > 
> > Signed-off-by: Nick Dokos <nicholas.dokos@...com>
> 
> Added to the e2fsprogs pu branch / 64-bit patch set.
> 
> BTW, note that this patch by itself caused the regression test suite
> to explode spectactularly, since there was a number of printf-style
> format statements that had to be changed so that dumpe2fs, debugfs
> et. al, would work correctly after changing the above-mentioned
> routines to return 32-bit values instead of 64-bit values.
> 
> I've fixed this before adding it to the e2fsprogs patch set.
> 
> Even though we do need to add more 64-bit tests, I do appreciate it if
> people could test their patches using "make check" before sending
> patches them to the ext4 list.
> 

Apologies for the breakage, but I invariably do "make check" and I got
no failures on the "make check" step (log appended). I probably should
have ported them to a 32-bit platform and tested there but I did not. Is
that where the failures arose?

Thanks,
Nick


View attachment "make.check.log" of type "text/plain" (23391 bytes)