linux-ext4 - Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2009 14:26:39 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	nicholas.dokos@...com
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags_ interfaces

Nick Dokos wrote:
>> ...  				}
>> diff --git a/e2fsck/super.c b/e2fsck/super.c
>> index 409d472..b8eee6b 100644
>> --- a/e2fsck/super.c
>> +++ b/e2fsck/super.c
>> @@ -637,8 +637,8 @@ void check_super_block(e2fsck_t ctx)
>>  		should_be = 0;
>>  		if (!ext2fs_group_desc_csum_verify(fs, i)) {
>>  			if (fix_problem(ctx, PR_0_GDT_CSUM, &pctx)) {
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
>> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT);
>> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_INODE_UNINIT);
>>  				ext2fs_bg_itable_unused_set(fs, i, 0);
>>  				should_be = 1;
>>  			}
> 
> Wouldn't something like this be better? There are a few places where this
> could be done:

thought about that, but it goes over 80cols and only a couple places, 
*shrug*

-Eric

> 
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_BLOCK_UNINIT);
>> -				ext2fs_bg_flag_clear (fs, i, EXT2_BG_INODE_UNINIT);
>> +				ext2fs_bg_flags_clear(fs, i, EXT2_BG_BLOCK_UNINIT | EXT2_BG_INODE_UNINIT);
> 
> 
> Thanks,
> Nick

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html