linux-ext4 - Re: [PATCH 3/3] e4defrag: avoid unsuccessful return in non-privileged user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Sep 2009 14:37:24 -0400
From:	Greg Freemyer <greg.freemyer@...il.com>
To:	Kazuya Mio <k-mio@...jp.nec.com>
Cc:	linux-ext4@...r.kernel.org, Theodore Tso <tytso@....edu>
Subject: Re: [PATCH 3/3] e4defrag: avoid unsuccessful return in non-privileged 
	user

2009/9/30 Kazuya Mio <k-mio@...jp.nec.com>:
> If non-privileged user does e4defrag, e4defrag returns 1 despite
> its success. This patch fixes this problem.
>
> Signed-off-by: Kazuya Mio <k-mio@...jp.nec.com>
> ---
>
>  e4defrag.c |    1 +
>  1 file changed, 1 insertion(+)
> diff --git a/misc/e4defrag.c b/misc/e4defrag.c
> index 94f8529..98dda92 100644
> --- a/misc/e4defrag.c
> +++ b/misc/e4defrag.c
> @@ -2025,6 +2025,7 @@ int main(int argc, char *argv[])
>                                if (!(mode_flag & DETAIL) &&
>                                                current_uid != ROOT_UID) {
>                                        printf(" Done.\n");
> +                                       success_flag = 1;
>                                        continue;
>                                }

I should know this, but this patch made me wonder about the underlying
implementation of EXT4_IOC_MOVE_EXT.

After EXT4_IOC_MOVE_EXT is called, can userspace somehow modify the
defragged file?

ie. If I only have readonly access to a file and I call
EXT4_IOC_MOVE_EXT to replace some of the data blocks, is it possible
now for me to write data to the donor_fd and thus modify the data in
the original file?

Greg
-- 
Greg Freemyer
Head of EDD Tape Extraction and Processing team
Litigation Triage Solutions Specialist
http://www.linkedin.com/in/gregfreemyer
Preservation and Forensic processing of Exchange Repositories White Paper -
<http://www.norcrossgroup.com/forms/whitepapers/tng_whitepaper_fpe.html>

The Norcross Group
The Intersection of Evidence & Technology
http://www.norcrossgroup.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html