linux-ext4 - [PATCH] ext4: in ext4_dirty_inode() current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat,  3 Oct 2009 00:20:48 +0200
From:	Tobias Doerffel <tobias.doerffel@...il.com>
To:	linux-ext4@...r.kernel.org
Cc:	Tobias Doerffel <tobias.doerffel@...il.com>
Subject: [PATCH] ext4: in ext4_dirty_inode() current_handle only needed for debugging

As of d3d1faf6a74496ea4435fd057c6a2cad49f3e523 in ext4_dirty_inode()
the current_handle variable is only used for debugging now. Therefore
compiling fs/ext4/inode.c without JBD_DEBUG set will result in a
compiler warning:

fs/ext4/inode.c: In function ‘ext4_dirty_inode’:
fs/ext4/inode.c:5818: warning: unused variable ‘current_handle’

This commit fixes the issue by adding an according #ifdef directive.
---
 fs/ext4/inode.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 26f1a0a..e5daa6c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5815,7 +5815,9 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode)
  */
 void ext4_dirty_inode(struct inode *inode)
 {
+#ifdef CONFIG_JBD_DEBUG
 	handle_t *current_handle = ext4_journal_current_handle();
+#endif
 	handle_t *handle;
 
 	handle = ext4_journal_start(inode, 2);
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html