linux-ext4 - Re: [PATCH 1/3] [RFC] vfs: add generic reserved space management interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Dec 2009 10:00:19 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	aneesh.kumar@...ux.vnet.ibm.com, cmm@...ibm.com,
	linux-fsdevel@...r.kernel.org, Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH 1/3] [RFC] vfs: add generic reserved space management
	interface

On Wed, Dec 09, 2009 at 05:51:17PM +0300, Dmitry Monakhov wrote:
> >From other point of view, we may change inode structure like this:
> struct quota_ptr
> {
>         struct dquot            *dquot[MAXQUOTAS];
> };
> struct quota_rsv_ptr
> {
>         struct dquot            *dquot[MAXQUOTAS];
>         qsize_t                 reservation;
> };
> struct inode {
> ....
> #ifdef CONFIG_QUOTA
>        union {
>              struct quota_ptr i_dquot;
>              struct quota_rsv_ptr i_dquot_rsv;
>        };
> #endif
> ....
> };

What's wrong with:

#ifdef CONFIG_QUOTA
	union {
		struct dquot	*i_dquot[MAXQUOTAS];
		struct quota_rsv_ptr i_dquot_rsv;
	};
#endif


voila, no changes needed.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html