linux-ext4 - Re: [PATCH] Ext4: wait for log to commit when putting super V2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Dec 2009 22:10:54 -0500
From:	tytso@....edu
To:	Josef Bacik <josef@...hat.com>
Cc:	linux-ext4@...r.kernel.org, sandeen@...hat.com
Subject: Re: [PATCH] Ext4: wait for log to commit when putting super V2.

On Mon, Dec 07, 2009 at 04:00:44PM -0500, Josef Bacik wrote:
> Update:
> -Instead of adding new logic to wait for the journal to commit, just move the
> cleanup code below the journal destruction which does the same thing.  Thanks to
> Eric Sandeen for the suggestion.
> 
> There is a problem where a transaction will be committing while we're unmounting
> the filesystem and you will get a panic because EXT4_SB(sb)->s_group_info has
> been kfree'ed in ext4_put_super.  The commit code does the callback for the
> mballoc stuff to release free'ed blocks in the transaction and panic's trying to
> access s_group_info.  The fix is to wait for the transaction to finish
> committing before we start cleaning up the mballoc stuff.  This patch hasn't
> been tested yet, but its an obvious fix.

Added to the ext4 patch queue, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html