lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Dec 2009 09:39:07 -0600 From: "Serge E. Hallyn" <serue@...ibm.com> To: Liuwenyi <qingshenlwy@...il.com> Cc: viro@...iv.linux.org.uk, jmorris@...ei.org, joel.becker@...cle.com, hch@....de, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, strongzgy@...il.com, onlyflyer@...il.com Subject: Re: [PATCHv2 03/12]posix_acl: Add the check items Quoting Liuwenyi (qingshenlwy@...il.com): > move the ACL validation check in to fs/posix_acl.c. > Including nullpointer check and PTR_ERR check. > > --- > Signed-off-by: Liuwenyi <qingshenlwy@...il.com> > Cc: Al Viro <viro@...iv.linux.org.uk> > Cc: James Morris <jmorris@...ei.org> > Cc: Joel Becker <joel.becker@...cle.com> > Cc: Serge Hallyn <serue@...ibm.com> > Cc: Christoph Hellwig <hch@....de> > Cc: linux-ext4@...r.kernel.org > Cc: linux-kernel@...r.kernel.org > > --- > diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c > index a99e543..480fe88 100644 > --- a/fs/ext2/acl.c > +++ b/fs/ext2/acl.c > @@ -403,13 +403,11 @@ ext2_xattr_set_acl(struct dentry *dentry, const > char *name, const void *value, > > if (value) { > acl = posix_acl_from_xattr(value, size); > - if (IS_ERR(acl)) > - return PTR_ERR(acl); > - else if (acl) { > - error = posix_acl_valid(acl); > - if (error) > - goto release_and_out; > - } > + > + error = posix_acl_valid(acl); > + if (error) > + goto release_and_out; Don't you also need to either update posix_acl_release() in your first patch to handle IS_ERR(acl), or else update the release_and_out: path in each caller? > + > } else > acl = NULL; > > > -- > Best Regards, > Liuwenyi -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists