lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Feb 2010 11:53:54 -0800 (PST) From: number9652 <number9652@...oo.com> To: Andreas Dilger <adilger@....com>, Eric Sandeen <sandeen@...hat.com> Cc: Theodore Ts'o <tytso@....edu>, ext4 development <linux-ext4@...r.kernel.org>, Shuichi Ihara <ihara@....com> Subject: Re: [PATCH] mk2fs lazy_journal_init option I hope you decide to continue unconditionally zeroing the journal at mkfs time. In this case, block_iterate2 was being used to create a file, but when the file became big enough to have an extent leaf, ext2fs_get_extent was returning an extent when it shouldn't have been. That caused ext2fs_block_iterate2 to go wrong, eventually calling mkjournal_proc millions of times more than it needed to (during which it would immediately return). A patch which resolves this is below. It shows normal mkfs times for me with a 512 MB journal and passes make check. Signed-off-by Nic Case <number9652@...oo.com> --- lib/ext2fs/extent-orig.c 2010-02-05 08:58:41.000000000 -0600 +++ lib/ext2fs/extent.c 2010-02-19 13:37:32.000000000 -0600 @@ -307,16 +307,12 @@ op = EXT2_EXTENT_DOWN; } else if (path->left > 0) op = EXT2_EXTENT_NEXT_SIB; - else if (handle->level > 0) - op = EXT2_EXTENT_UP; else return EXT2_ET_EXTENT_NO_NEXT; } else { /* leaf node */ if (path->left > 0) op = EXT2_EXTENT_NEXT_SIB; - else if (handle->level > 0) - op = EXT2_EXTENT_UP; else return EXT2_ET_EXTENT_NO_NEXT; } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists