| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 06 Mar 2010 18:33:48 +0530
From: "Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To: "Theodore Ts'o" <tytso@....edu>,
Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc: Frank Mayhar <fmayhar@...gle.com>, "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_error()
instead
On Tue, 2 Mar 2010 13:18:44 -0500, "Theodore Ts'o" <tytso@....edu> wrote:
> From: Frank Mayhar <fmayhar@...gle.com>
>
> Convert a bunch of BUG_ONs to emit a ext4_error() message and return
> EIO. This is a first pass and most notably does _not_ cover
> mballoc.c, which is a morass of void functions.
>
> Signed-off-by: Frank Mayhar <fmayhar@...gle.com>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
> fs/ext4/ext4.h | 10 +++
> fs/ext4/extents.c | 189 +++++++++++++++++++++++++++++++++++++++++------------
> fs/ext4/inode.c | 18 +++++-
> fs/ext4/super.c | 36 ++++++++++
> 4 files changed, 209 insertions(+), 44 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 79c067e..350c3a2 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -53,6 +53,12 @@
> #define ext4_debug(f, a...) do {} while (0)
> #endif
>
> +#define EXT4_ERROR_INODE(inode, fmt, a...) \
> + ext4_error_inode(__func__, (inode), (fmt), ## a);
> +
> +#define EXT4_ERROR_FILE(file, fmt, a...) \
> + ext4_error_file(__func__, (file), (fmt), ## a);
> +
I guess ext4_error and ext4_warning are now not taking __func__. So we
to be consistant with thos i this this can be in lower case eventhough
they are #defines.
> /* data type for block offset of block group */
> typedef int ext4_grpblk_t;
>
> @@ -1492,6 +1498,10 @@ extern int ext4_group_extend(struct super_block *sb,
> extern void __ext4_error(struct super_block *, const char *, const char *, ...)
> __attribute__ ((format (printf, 3, 4)));
> #define ext4_error(sb, message...) __ext4_error(sb, __func__, ## message)
> +extern void ext4_error_inode(const char *, struct inode *, const char *, ...)
> + __attribute__ ((format (printf, 3, 4)));
> +extern void ext4_error_file(const char *, struct file *, const char *, ...)
> + __attribute__ ((format (printf, 3, 4)));
> extern void __ext4_std_error(struct super_block *, const char *, int);
> extern void ext4_abort(struct super_block *, const char *, const char *, ...)
> __attribute__ ((format (printf, 3, 4)));
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 202667b..45dad87 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -703,7 +703,12 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block,
> }
> eh = ext_block_hdr(bh);
> ppos++;
> - BUG_ON(ppos > depth);
> + if (unlikely(ppos > depth)) {
> + put_bh(bh);
> + EXT4_ERROR_INODE(inode,
> + "ppos %d > depth %d", ppos, depth);
> + goto err;
> + }
> path[ppos].p_bh = bh;
> path[ppos].p_hdr = eh;
> i--;
> @@ -749,7 +754,12 @@ int ext4_ext_insert_index(handle_t *handle, struct inode *inode,
> if (err)
> return err;
>
> - BUG_ON(logical == le32_to_cpu(curp->p_idx->ei_block));
> + if (unlikely(logical == le32_to_cpu(curp->p_idx->ei_block))) {
> + EXT4_ERROR_INODE(inode,
> + "logical %d == ei_block %d!",
> + logical, le32_to_cpu(curp->p_idx->ei_block));
> + return -EIO;
> + }
> len = EXT_MAX_INDEX(curp->p_hdr) - curp->p_idx;
> if (logical > le32_to_cpu(curp->p_idx->ei_block)) {
> /* insert after */
> @@ -779,9 +789,17 @@ int ext4_ext_insert_index(handle_t *handle, struct inode *inode,
> ext4_idx_store_pblock(ix, ptr);
> le16_add_cpu(&curp->p_hdr->eh_entries, 1);
>
> - BUG_ON(le16_to_cpu(curp->p_hdr->eh_entries)
> - > le16_to_cpu(curp->p_hdr->eh_max));
> - BUG_ON(ix > EXT_LAST_INDEX(curp->p_hdr));
> + if (unlikely(le16_to_cpu(curp->p_hdr->eh_entries)
> + > le16_to_cpu(curp->p_hdr->eh_max))) {
> + EXT4_ERROR_INODE(inode,
> + "logical %d == ei_block %d!",
> + logical, le32_to_cpu(curp->p_idx->ei_block));
> + return -EIO;
> + }
> + if (unlikely(ix > EXT_LAST_INDEX(curp->p_hdr))) {
> + EXT4_ERROR_INODE(inode, "ix > EXT_LAST_INDEX!");
> + return -EIO;
> + }
>
> err = ext4_ext_dirty(handle, inode, curp);
> ext4_std_error(inode->i_sb, err);
> @@ -819,7 +837,10 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
>
> /* if current leaf will be split, then we should use
> * border from split point */
> - BUG_ON(path[depth].p_ext > EXT_MAX_EXTENT(path[depth].p_hdr));
> + if (unlikely(path[depth].p_ext > EXT_MAX_EXTENT(path[depth].p_hdr))) {
> + EXT4_ERROR_INODE(inode, "p_ext > EXT_MAX_EXTENT!");
> + return -EIO;
> + }
> if (path[depth].p_ext != EXT_MAX_EXTENT(path[depth].p_hdr)) {
> border = path[depth].p_ext[1].ee_block;
> ext_debug("leaf will be split."
> @@ -860,7 +881,11 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
>
> /* initialize new leaf */
> newblock = ablocks[--a];
> - BUG_ON(newblock == 0);
> + if (unlikely(newblock == 0)) {
> + EXT4_ERROR_INODE(inode, "newblock == 0!");
> + err = -EIO;
> + goto cleanup;
> + }
> bh = sb_getblk(inode->i_sb, newblock);
> if (!bh) {
> err = -EIO;
> @@ -880,7 +905,14 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
> ex = EXT_FIRST_EXTENT(neh);
>
> /* move remainder of path[depth] to the new leaf */
> - BUG_ON(path[depth].p_hdr->eh_entries != path[depth].p_hdr->eh_max);
> + if (unlikely(path[depth].p_hdr->eh_entries !=
> + path[depth].p_hdr->eh_max)) {
> + EXT4_ERROR_INODE(inode, "eh_entries %d != eh_max %d!",
> + path[depth].p_hdr->eh_entries,
> + path[depth].p_hdr->eh_max);
> + err = -EIO;
> + goto cleanup;
> + }
> /* start copy from next extent */
> /* TODO: we could do it by single memmove */
> m = 0;
> @@ -927,7 +959,11 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
>
> /* create intermediate indexes */
> k = depth - at - 1;
> - BUG_ON(k < 0);
> + if (unlikely(k < 0)) {
> + EXT4_ERROR_INODE(inode, "k %d < 0!", k);
> + err = -EIO;
> + goto cleanup;
> + }
> if (k)
> ext_debug("create %d intermediate indices\n", k);
> /* insert new index into current index block */
> @@ -964,8 +1000,14 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
>
> ext_debug("cur 0x%p, last 0x%p\n", path[i].p_idx,
> EXT_MAX_INDEX(path[i].p_hdr));
> - BUG_ON(EXT_MAX_INDEX(path[i].p_hdr) !=
> - EXT_LAST_INDEX(path[i].p_hdr));
> + if (unlikely(EXT_MAX_INDEX(path[i].p_hdr) !=
> + EXT_LAST_INDEX(path[i].p_hdr))) {
> + EXT4_ERROR_INODE(inode,
> + "EXT_MAX_INDEX != EXT_LAST_INDEX ee_block %d!",
> + le32_to_cpu(path[i].p_ext->ee_block));
> + err = -EIO;
> + goto cleanup;
> + }
> while (path[i].p_idx <= EXT_MAX_INDEX(path[i].p_hdr)) {
> ext_debug("%d: move %d:%llu in new index %llu\n", i,
> le32_to_cpu(path[i].p_idx->ei_block),
> @@ -1203,7 +1245,10 @@ ext4_ext_search_left(struct inode *inode, struct ext4_ext_path *path,
> struct ext4_extent *ex;
> int depth, ee_len;
>
> - BUG_ON(path == NULL);
> + if (unlikely(path == NULL)) {
> + EXT4_ERROR_INODE(inode, "path == NULL *logical %d!", *logical);
> + return -EIO;
> + }
> depth = path->p_depth;
> *phys = 0;
>
> @@ -1217,15 +1262,33 @@ ext4_ext_search_left(struct inode *inode, struct ext4_ext_path *path,
> ex = path[depth].p_ext;
> ee_len = ext4_ext_get_actual_len(ex);
> if (*logical < le32_to_cpu(ex->ee_block)) {
> - BUG_ON(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex);
> + if (unlikely(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex)) {
> + EXT4_ERROR_INODE(inode,
> + "EXT_FIRST_EXTENT != ex *logical %d ee_block %d!",
> + *logical, le32_to_cpu(ex->ee_block));
> + return -EIO;
> + }
> while (--depth >= 0) {
> ix = path[depth].p_idx;
> - BUG_ON(ix != EXT_FIRST_INDEX(path[depth].p_hdr));
> + if (unlikely(ix != EXT_FIRST_INDEX(path[depth].p_hdr))) {
> + EXT4_ERROR_INODE(inode,
> + "ix (%d) != EXT_FIRST_INDEX (%d) (depth %d)!",
> + ix != NULL ? ix->ei_block : 0,
> + EXT_FIRST_INDEX(path[depth].p_hdr) != NULL ?
> + EXT_FIRST_INDEX(path[depth].p_hdr)->ei_block : 0,
> + depth);
> + return -EIO;
> + }
> }
> return 0;
> }
>
> - BUG_ON(*logical < (le32_to_cpu(ex->ee_block) + ee_len));
> + if (unlikely(*logical < (le32_to_cpu(ex->ee_block) + ee_len))) {
> + EXT4_ERROR_INODE(inode,
> + "logical %d < ee_block %d + ee_len %d!",
> + *logical, le32_to_cpu(ex->ee_block), ee_len);
> + return -EIO;
> + }
>
> *logical = le32_to_cpu(ex->ee_block) + ee_len - 1;
> *phys = ext_pblock(ex) + ee_len - 1;
> @@ -1251,7 +1314,10 @@ ext4_ext_search_right(struct inode *inode, struct ext4_ext_path *path,
> int depth; /* Note, NOT eh_depth; depth from top of tree */
> int ee_len;
>
> - BUG_ON(path == NULL);
> + if (unlikely(path == NULL)) {
> + EXT4_ERROR_INODE(inode, "path == NULL *logical %d!", *logical);
> + return -EIO;
> + }
> depth = path->p_depth;
> *phys = 0;
>
> @@ -1265,17 +1331,32 @@ ext4_ext_search_right(struct inode *inode, struct ext4_ext_path *path,
> ex = path[depth].p_ext;
> ee_len = ext4_ext_get_actual_len(ex);
> if (*logical < le32_to_cpu(ex->ee_block)) {
> - BUG_ON(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex);
> + if (unlikely(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex)) {
> + EXT4_ERROR_INODE(inode,
> + "first_extent(path[%d].p_hdr) != ex",
> + depth);
> + return -EIO;
> + }
> while (--depth >= 0) {
> ix = path[depth].p_idx;
> - BUG_ON(ix != EXT_FIRST_INDEX(path[depth].p_hdr));
> + if (unlikely(ix != EXT_FIRST_INDEX(path[depth].p_hdr))) {
> + EXT4_ERROR_INODE(inode,
> + "ix != EXT_FIRST_INDEX *logical %d!",
> + *logical);
> + return -EIO;
> + }
> }
> *logical = le32_to_cpu(ex->ee_block);
> *phys = ext_pblock(ex);
> return 0;
> }
>
> - BUG_ON(*logical < (le32_to_cpu(ex->ee_block) + ee_len));
> + if (unlikely(*logical < (le32_to_cpu(ex->ee_block) + ee_len))) {
> + EXT4_ERROR_INODE(inode,
> + "logical %d < ee_block %d + ee_len %d!",
> + *logical, le32_to_cpu(ex->ee_block), ee_len);
> + return -EIO;
> + }
>
> if (ex != EXT_LAST_EXTENT(path[depth].p_hdr)) {
> /* next allocated block in this leaf */
> @@ -1414,8 +1495,12 @@ static int ext4_ext_correct_indexes(handle_t *handle, struct inode *inode,
>
> eh = path[depth].p_hdr;
> ex = path[depth].p_ext;
> - BUG_ON(ex == NULL);
> - BUG_ON(eh == NULL);
> +
> + if (unlikely(ex == NULL || eh == NULL)) {
> + EXT4_ERROR_INODE(inode,
> + "ex %p == NULL or eh %p == NULL", ex, eh);
> + return -EIO;
> + }
>
> if (depth == 0) {
> /* there is no tree at all */
> @@ -1613,10 +1698,16 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
> ext4_lblk_t next;
> unsigned uninitialized = 0;
>
> - BUG_ON(ext4_ext_get_actual_len(newext) == 0);
> + if (unlikely(ext4_ext_get_actual_len(newext) == 0)) {
> + EXT4_ERROR_INODE(inode, "ext4_ext_get_actual_len(newext) == 0");
> + return -EIO;
> + }
> depth = ext_depth(inode);
> ex = path[depth].p_ext;
> - BUG_ON(path[depth].p_hdr == NULL);
> + if (unlikely(path[depth].p_hdr == NULL)) {
> + EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth);
> + return -EIO;
> + }
>
> /* try to insert block into found extent and return */
> if (ex && !(flag & EXT4_GET_BLOCKS_PRE_IO)
> @@ -1788,7 +1879,11 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block,
> }
>
> depth = ext_depth(inode);
> - BUG_ON(path[depth].p_hdr == NULL);
> + if (unlikely(path[depth].p_hdr == NULL)) {
> + EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth);
> + err = -EIO;
> + break;
> + }
> ex = path[depth].p_ext;
> next = ext4_ext_next_allocated_block(path);
>
> @@ -1839,7 +1934,11 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block,
> cbex.ec_type = EXT4_EXT_CACHE_EXTENT;
> }
>
> - BUG_ON(cbex.ec_len == 0);
> + if (unlikely(cbex.ec_len == 0)) {
> + EXT4_ERROR_INODE(inode, "cbex.ec_len == 0");
> + err = -EIO;
> + break;
> + }
> err = func(inode, path, &cbex, ex, cbdata);
> ext4_ext_drop_refs(path);
>
> @@ -1982,7 +2081,10 @@ static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode,
> /* free index block */
> path--;
> leaf = idx_pblock(path->p_idx);
> - BUG_ON(path->p_hdr->eh_entries == 0);
> + if (unlikely(path->p_hdr->eh_entries == 0)) {
> + EXT4_ERROR_INODE(inode, "path->p_hdr->eh_entries == 0");
> + return -EIO;
> + }
> err = ext4_ext_get_access(handle, inode, path);
> if (err)
> return err;
> @@ -2120,8 +2222,10 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode,
> if (!path[depth].p_hdr)
> path[depth].p_hdr = ext_block_hdr(path[depth].p_bh);
> eh = path[depth].p_hdr;
> - BUG_ON(eh == NULL);
> -
> + if (unlikely(path[depth].p_hdr == NULL)) {
> + EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth);
> + return -EIO;
> + }
> /* find where to start removing */
> ex = EXT_LAST_EXTENT(eh);
>
> @@ -3240,10 +3344,10 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode,
> * this situation is possible, though, _during_ tree modification;
> * this is why assert can't be put in ext4_ext_find_extent()
> */
> - if (path[depth].p_ext == NULL && depth != 0) {
> - ext4_error(inode->i_sb, "bad extent address "
> - "inode: %lu, iblock: %d, depth: %d",
> - inode->i_ino, iblock, depth);
> + if (unlikely(path[depth].p_ext == NULL && depth != 0)) {
> + EXT4_ERROR_INODE(inode, "bad extent address "
> + "iblock: %d, depth: %d pblock %lld",
> + iblock, depth, path[depth].p_block);
> err = -EIO;
> goto out2;
> }
> @@ -3371,16 +3475,17 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode,
> }
>
> if (unlikely(EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL)) {
> - if (eh->eh_entries) {
> - last_ex = EXT_LAST_EXTENT(eh);
> - if (iblock + ar.len > le32_to_cpu(last_ex->ee_block)
> - + ext4_ext_get_actual_len(last_ex))
> - EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL;
> - } else {
> - WARN_ON(eh->eh_entries == 0);
> - ext4_error(inode->i_sb, __func__,
> - "inode#%lu, eh->eh_entries = 0!", inode->i_ino);
> - }
> + if (unlikely(!eh->eh_entries)) {
> + EXT4_ERROR_INODE(inode,
> + "eh->eh_entries == 0 ee_block %d",
> + ex->ee_block);
> + err = -EIO;
> + goto out2;
> + }
> + last_ex = EXT_LAST_EXTENT(eh);
> + if (iblock + ar.len > le32_to_cpu(last_ex->ee_block)
> + + ext4_ext_get_actual_len(last_ex))
> + EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL;
> }
> err = ext4_ext_insert_extent(handle, inode, path, &newex, flags);
> if (err) {
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 576bbe2..2c48fbe 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -607,7 +607,14 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode,
> if (*err)
> goto failed_out;
>
> - BUG_ON(current_block + count > EXT4_MAX_BLOCK_FILE_PHYS);
> + if (unlikely(current_block + count > EXT4_MAX_BLOCK_FILE_PHYS)) {
> + EXT4_ERROR_INODE(inode,
> + "current_block %llu + count %lu > %d!",
> + current_block, count,
> + EXT4_MAX_BLOCK_FILE_PHYS);
> + *err = -EIO;
> + goto failed_out;
> + }
>
> target -= count;
> /* allocate blocks for indirect blocks */
> @@ -643,7 +650,14 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode,
> ar.flags = EXT4_MB_HINT_DATA;
>
> current_block = ext4_mb_new_blocks(handle, &ar, err);
> - BUG_ON(current_block + ar.len > EXT4_MAX_BLOCK_FILE_PHYS);
> + if (unlikely(current_block + ar.len > EXT4_MAX_BLOCK_FILE_PHYS)) {
> + EXT4_ERROR_INODE(inode,
> + "current_block %llu + ar.len %d > %d!",
> + current_block, ar.len,
> + EXT4_MAX_BLOCK_FILE_PHYS);
> + *err = -EIO;
> + goto failed_out;
> + }
>
> if (*err && (target == blks)) {
> /*
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 200d257..6c8e92c 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -347,6 +347,42 @@ void __ext4_error(struct super_block *sb, const char *function,
> ext4_handle_error(sb);
> }
>
> +void ext4_error_inode(const char *function, struct inode *inode,
> + const char *fmt, ...)
> +{
> + va_list args;
> +
> + va_start(args, fmt);
> + printk(KERN_CRIT "EXT4-fs error (device %s): %s: inode #%lu: (comm %s) ",
> + inode->i_sb->s_id, function, inode->i_ino, current->comm);
> + vprintk(fmt, args);
> + printk("\n");
> + va_end(args);
> +
> + ext4_handle_error(inode->i_sb);
> +}
> +
> +void ext4_error_file(const char *function, struct file *file,
> + const char *fmt, ...)
> +{
> + va_list args;
> + struct inode *inode = file->f_dentry->d_inode;
> + char pathname[80], *path;
> +
> + va_start(args, fmt);
> + path = d_path(&(file->f_path), pathname, sizeof(pathname));
> + if (!path)
> + path = "(unknown)";
> + printk(KERN_CRIT
> + "EXT4-fs error (device %s): %s: inode #%lu (comm %s path %s): ",
> + inode->i_sb->s_id, function, inode->i_ino, current->comm, path);
> + vprintk(fmt, args);
> + printk("\n");
> + va_end(args);
> +
> + ext4_handle_error(inode->i_sb);
> +}
-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists