linux-ext4 - Re: [PATCH] ext4: memory leakage in ext4_mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 04 Apr 2010 23:59:00 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	jing zhang <zj.barak@...il.com>
CC:	tytso@....edu,
	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: memory leakage in ext4_mb_init()

jing zhang wrote:
> 2010/4/5, Eric Sandeen <sandeen@...hat.com>:
>> jing zhang wrote:
>>> 2010/4/5, tytso@....edu <tytso@....edu>:
>>>> On Sun, Apr 04, 2010 at 09:05:14AM +0800, jing zhang wrote:
>>>>
>>>> How much testing are you doing before submitting patches, out of
>>>> curiosity?
>>> Yes, Ted, it is curiosity that drives me to do hard works, including patch
>>> ext4.
>> It is the language barrier that is making some of this difficult,
>> but I'm not complaining - you speak English much better than I speak any
> 
> You are good guy:) Is English your native language? And, I am curious,
> what is the second language you are able to speak, Eric?

Only a little German.

>> second language.  :)
>>
>> Ted meant that -he- was curious about how much testing you were doing.
> 
> How do know what Ted meant, by iphone?

No, because I am a native English speaker and I understood the 
figure of speech.  ("out of curiosity")

> I am not good at testing, partially because it is hard to setup the
> required environment, sometimes several hard disks are needed, maybe a
> few boxes, but I try to analyse the C code while reading and
> understanding the works by great maintainers and developers of Linux
> kernel.

Testing really is critical to development; some things can be done by
inspection, but if you don't test it is hard to know if you made a
mistake.

You can always test inside a vm, or on a loopback file, on a single box.

Without testing, you are asking others to do testing for you
(unless the change is so obvious that it can be trusted) 

-Eric
 
>                 - zj


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html