lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Apr 2010 03:23:03 -0600 From: Andreas Dilger <adilger@....com> To: coly.li@...e.de Cc: Nikanth Karthikesan <knikanth@...e.de>, Nick Piggin <npiggin@...e.de>, Alexander Viro <viro@...iv.linux.org.uk>, linux-fsdevel@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Eelis <opensuse.org@...tacts.eelis.net> Subject: Re: [PATCH] Prevent creation of files larger than RLIMIT_FSIZE using fallocate On 2010-04-29, at 00:13, Coly Li wrote: >> + /* >> + * Let individual file system decide if it supports >> + * preallocation for directories or not. >> + */ >> + if (offset > inode->i_sb->s_maxbytes) >> + return -EFBIG; > > For file systems support online-resize, like ext4 and ocfs2, should we also need a locking to protect inode->i_sb->s_mabytes ? s_maxbytes is the maximum theoretical single file size, and has nothing to do with the size of the filesystem. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists