linux-ext4 - Re: [PATCH, RFC] support discard in non-journal ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 May 2010 17:29:45 -0700
From:	Jiaying Zhang <jiayingz@...gle.com>
To:	coly.li@...e.de
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH, RFC] support discard in non-journal ext4

On Thu, May 13, 2010 at 2:08 AM, Coly Li <coly.li@...e.de> wrote:
>
>
> On 05/13/2010 01:00 PM, Jiaying Zhang Wrote:
> > This patch issues discard request for freed blocks in ext4_free_blocks()
> > if ext4 is mounted with discard option and without journal.
> >
> > Author: Jiaying Zhang <jiayingz@...gle.com>
> > Date:   Wed May 12 21:11:46 2010 -0700
> >
> >     Issue discard request in ext4_free_blocks() when ext4 has no journal and
> >     is mounted with discard option.
> >
> >     Signed-off-by: Jiaying Zhang <jiayingz@...gle.com>
> >
> > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> > index a291cc3..d51b79a 100644
> > --- a/fs/ext4/mballoc.c
> > +++ b/fs/ext4/mballoc.c
> > @@ -2513,6 +2513,22 @@ int ext4_mb_release(struct super_block *sb)
> >       return 0;
> >  }
> >
> > +static void ext4_issue_discard(struct super_block *sb, ext4_group_t block_group,
> > +             ext4_grpblk_t block, int count)
> > +{
> > +     int ret;
> > +     ext4_fsblk_t discard_block;
> > +
> > +     discard_block = block + ext4_group_first_block_no(sb, block_group);
> > +     trace_ext4_discard_blocks(sb,
> > +                     (unsigned long long) discard_block, count);
> > +     ret = sb_issue_discard(sb, discard_block, count);
> > +     if (ret == EOPNOTSUPP) {
> > +             ext4_warning(sb, "discard not supported, disabling");
> > +             clear_opt(EXT4_SB(sb)->s_mount_opt, DISCARD);
> > +     }
> > +}
> > +
>
> How about make it as an inline routine? Thanks.

Ok. I changed it to inline. The modified patch is attached.

Thanks!

Jiaying

>
> --
> Coly Li
> SuSE Labs

View attachment "ext4-discard-nojournal.v2.patch" of type "text/x-patch" (2421 bytes)