| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Jun 2010 13:54:40 +0200 From: Jan Kara <jack@...e.cz> To: Dmitry Monakhov <dmonakhov@...nvz.org> Cc: Jan Kara <jack@...e.cz>, tytso@....edu, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: Always journal quota file modifications On Thu 03-06-10 13:07:41, Dmitry Monakhov wrote: > Jan Kara <jack@...e.cz> writes: > > > When journaled quota options are not specified, we do writes > > to quota files just in data=ordered mode. This actually causes > > warnings from JBD2 about dirty journaled buffer because ext4_getblk > > unconditionally treats a block allocated by it as metadata. Since > > quota actually is filesystem metadata, the easiest way to get rid > > of the warning is to always treat quota writes as metadata... > Absolutely agree with the fix, but I have a theoretical question. > Is is possible to solve the issue without handling quota's bh > via ext4_handle_dirty_metadata()? > As soon as i understand ext4_jbd2_file_inode() not works here > because bh is belongs to blkdev page-cache. In other words is it > possible provide ordering for blkdev's blocks in jbd2? You are right. It's not possible to provide ordering for blkdev's blocks in JBD2 (unlike JBD). So a different solution would be rather problematic. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists