lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Jun 2010 17:07:53 +0200 From: Jan Kara <jack@...e.cz> To: linux-fsdevel@...r.kernel.org Cc: David Woodhouse <dwmw2@...radead.org>, Al Viro <viro@...iv.linux.org.uk>, Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz> Subject: [PATCH 2/4] vfs: update ctime when changing the file's permission by setfacl generic_acl_set didn't update the ctime of the file when its permission was changed. Steps to reproduce: # touch aaa # stat -c %Z aaa 1275289822 # setfacl -m 'u::x,g::x,o::x' aaa # stat -c %Z aaa 1275289822 <- unchanged But, according to the spec of the ctime, vfs must update it. Port of ext3 patch by Miao Xie <miaox@...fujitsu.com>. CC: Al Viro <viro@...iv.linux.org.uk> Signed-off-by: Jan Kara <jack@...e.cz> --- fs/generic_acl.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/generic_acl.c b/fs/generic_acl.c index 99800e5..6bc9e3a 100644 --- a/fs/generic_acl.c +++ b/fs/generic_acl.c @@ -94,6 +94,7 @@ generic_acl_set(struct dentry *dentry, const char *name, const void *value, if (error < 0) goto failed; inode->i_mode = mode; + inode->i_ctime = CURRENT_TIME; if (error == 0) { posix_acl_release(acl); acl = NULL; -- 1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists