lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Aug 2010 13:45:03 -0700 From: Joel Becker <Joel.Becker@...cle.com> To: Jan Kara <jack@...e.cz> Cc: Eric Sandeen <sandeen@...hat.com>, Andreas Dilger <adilger@...ger.ca>, "Ted Ts'o" <tytso@....edu>, ocfs2-devel@....oracle.com, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, "linux-kernel@...r.kernel.org Patrick J. LoPresti" <lopresti@...il.com> Subject: Re: [Ocfs2-devel] [PATCH 1/3] ext3/ext4: Factor out disk addressability check On Mon, Aug 16, 2010 at 09:21:00PM +0200, Jan Kara wrote: > On Mon 16-08-10 12:13:19, Joel Becker wrote: > > On Mon, Aug 16, 2010 at 09:44:35AM -0500, Eric Sandeen wrote: > > > Joel Becker wrote: > > > > How about: > > > > > > > > u64 last_fs_page = last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits); > > > > > > > > ... || > > > > (last_fs_page > (pgoff_t)(~0ULL))) { > > > > > > > > Is that more readable? > > > > > > To me, yes. Maybe do similar for last_fs_sector. > > > > last_fs_sector would be shifting up, which could wrap a really > > large last_fs_blocks. So I'm going to keep the sector_t check as-is. > > How's this: > > > > >From 8de5cb9164cdc179ba84a07b282a895d0eb794b0 Mon Sep 17 00:00:00 2001 > > >From: Joel Becker <joel.becker@...cle.com> > > Date: Mon, 16 Aug 2010 12:10:17 -0700 > > Subject: [PATCH] libfs: Fix shift bug in generic_check_addressable() > > > > generic_check_addressable() erroneously shifts pages down by a block > > factor when it should be shifting up. To prevent overflow, we shift > > blocks down to pages. > > > > Signed-off-by: Joel Becker <joel.becker@...cle.com> > Looks good. > Reviewed-by: Jan Kara <jack@...e.cz> Ok, I'm going to keep this atop my existing branch, and if it all shakes out in linux-next for a few days, send it along. Joel -- "When ideas fail, words come in very handy." - Goethe Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@...cle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists