lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Aug 2010 01:42:25 -0600 From: Andreas Dilger <adilger@...ger.ca> To: Masayoshi MIZUMA <m.mizuma@...fujitsu.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>, linux-ext4 development <linux-ext4@...r.kernel.org> Subject: Re: [PATCH] ext3: set i_extra_isize of 11th inode On 2010-08-19, at 20:20, Masayoshi MIZUMA wrote: > In ext3 filesystem, if following conditions 1., 2., 3. and 4. is satisfied, > getfattr can't search the extended attribute (EA) after remount. > > This happens because of following logic: > i_extra_isize is set to over 0 by ext3_new_inode() when we create > a file whose inode number is 11 after removing "lost+found". > Therefore setfattr creates the EA in-inode. > After remount, i_extra_isize of 11th inode is set to 0 by ext3_iget() > when we lookup the file, so getfattr tries to search the EA out-inode. > However, the EA locates in-inode, so getfattr can't search the EA. This was a workaround for a bug in mke2fs a couple of years ago, and is probably no longer needed. > @@ -2881,8 +2881,7 @@ struct inode *ext3_iget(struct super_block *sb, unsigned long ino) > atomic_set(&ei->i_datasync_tid, tid); > } > > - if (inode->i_ino >= EXT3_FIRST_INO(inode->i_sb) + 1 && > - EXT3_INODE_SIZE(inode->i_sb) > EXT3_GOOD_OLD_INODE_SIZE) { > + if (EXT3_INODE_SIZE(inode->i_sb) > EXT3_GOOD_OLD_INODE_SIZE) { > /* > * When mke2fs creates big inodes it does not zero out > * the unused bytes above EXT3_GOOD_OLD_INODE_SIZE, This should also remove the above comment, which is no longer relevant. Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists